Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docs anchorjs links darker on keyboard focus #32050

Merged
merged 3 commits into from Nov 2, 2020

Conversation

patrickhlauke
Copy link
Member

Not just on mouse hover

@patrickhlauke patrickhlauke requested a review from a team as a code owner November 2, 2020 17:15
@patrickhlauke patrickhlauke added this to Inbox in v5.0.0-alpha3 via automation Nov 2, 2020
@patrickhlauke patrickhlauke added this to Inbox in v4.6.0 via automation Nov 2, 2020
@patrickhlauke
Copy link
Member Author

Current look when focused with keyboard - low/failing contrast ratio

contrast-bootstrap-docs-anchor

site/assets/scss/_anchor.scss Outdated Show resolved Hide resolved
Co-authored-by: Mark Otto <markd.otto@gmail.com>
v5.0.0-alpha3 automation moved this from Inbox to Approved Nov 2, 2020
@patrickhlauke
Copy link
Member Author

sorry, got mixed-up with the labels...meant for backport as well

@patrickhlauke patrickhlauke merged commit 3b64580 into main Nov 2, 2020
v5.0.0-alpha3 automation moved this from Approved to Shipped Nov 2, 2020
@patrickhlauke patrickhlauke deleted the patrickhlauke-docs-anchor-focus branch November 2, 2020 20:55
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked/Manually backported in v4.6.0 Nov 3, 2020
XhmikosR pushed a commit that referenced this pull request Nov 3, 2020
* Make docs anchorjs links darker on keyboard focus

Not just on mouse hover

* Update site/assets/scss/_anchor.scss

Co-authored-by: Mark Otto <markd.otto@gmail.com>

Co-authored-by: Mark Otto <markd.otto@gmail.com>
XhmikosR pushed a commit that referenced this pull request Nov 3, 2020
* Make docs anchorjs links darker on keyboard focus

Not just on mouse hover

* Update site/assets/scss/_anchor.scss

Co-authored-by: Mark Otto <markd.otto@gmail.com>

Co-authored-by: Mark Otto <markd.otto@gmail.com>
XhmikosR pushed a commit that referenced this pull request Nov 4, 2020
* Make docs anchorjs links darker on keyboard focus

Not just on mouse hover

* Update site/assets/scss/_anchor.scss

Co-authored-by: Mark Otto <markd.otto@gmail.com>

Co-authored-by: Mark Otto <markd.otto@gmail.com>
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Nov 5, 2020
XhmikosR pushed a commit that referenced this pull request Nov 5, 2020
* Make docs anchorjs links darker on keyboard focus

Not just on mouse hover

* Update site/assets/scss/_anchor.scss

Co-authored-by: Mark Otto <markd.otto@gmail.com>

Co-authored-by: Mark Otto <markd.otto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.6.0
Shipped
v5.0.0-alpha3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants