v4: Move negative margin-bottom from .nav-item to .nav-link #32211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
approved these changes
Nov 23, 2020
mdo
approved these changes
Dec 10, 2020
mdo
changed the title
This was referenced Mar 8, 2021
jrochkind
added a commit
to jrochkind/bootstrap4-responsive-tabs
that referenced
this pull request
Sep 9, 2021
In Bootstrap 4.6.0, as a result of twbs/bootstrap#32211, the bottom border is not visible in the responsive-tab in small mode. This fixes it.
jrochkind
added a commit
to jrochkind/bootstrap4-responsive-tabs
that referenced
this pull request
Sep 9, 2021
In Bootstrap 4.6.0, as a result of twbs/bootstrap#32211, the bottom border is not visible in the responsive-tab in small mode. This fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix prevents the tab's bottom border from showing on the actively selected tab. This bug is only visible when using
.nav-links as direct children of.nav-tabs.This issue can be reproduced in the second docs example under this link: https://getbootstrap.com/docs/4.5/components/navs/#javascript-behavior
Here is an image showing before/after the fix.
Preview: https://deploy-preview-32211--twbs-bootstrap.netlify.app/docs/4.5/components/navs/#javascript-behavior