Partially backport #32217 #32225
Merged
Partially backport #32217 #32225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused with the backports :/ |
XhmikosR
reviewed
Nov 21, 2020
| @@ -734,10 +734,6 @@ class Tooltip { | |||
| this.config.animation = initConfigAnimation | |||
| } | |||
|
|
|||
| _getCustomClass() { | |||
| return this.element.getAttribute('data-custom-class') || this.config.customClass | |||
There was a problem hiding this comment.
Because the customClass will be in the configuration already, even if it is provided in the data attributes 🤔
Lines 660 to 664 in 2d8c02e
Ref: #32217 (comment)
There was a problem hiding this comment.
And jQuery's addClass() method will handle it, either this.config.customClass is a function or a class name (Even it is a blank string)
These are not exactly the backports but minor fixes 🙂 |
XhmikosR
approved these changes
Nov 23, 2020
|
@rohit2sharma95 can you move the typo fixes to a new PR please? |
rohit2sharma95
force-pushed
the
tooltip-custom-class-v4
branch
from
1a610a7
to
2a45ea9
Compare
Johann-S
approved these changes
Nov 25, 2020
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially backport #32217