Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: move version_short variable under the config object #32737

Merged
merged 2 commits into from Jan 10, 2021

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 9, 2021

This is so that it works on npm 7.x too.

npm 7.x dropped support for this feature but still loads any config object variables. This patch should work on npm 6.x and 7.x.

@XhmikosR XhmikosR added this to Inbox in v4.6.0 via automation Jan 9, 2021
@XhmikosR XhmikosR requested a review from a team as a code owner January 9, 2021 12:01
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Jan 9, 2021
@XhmikosR XhmikosR requested a review from mdo January 9, 2021 12:06
@XhmikosR
Copy link
Member Author

XhmikosR commented Jan 9, 2021

You can see this working on https://github.com/twbs/bootstrap/compare/main-xmr-node-15

v5.0.0-beta2 automation moved this from Inbox to Approved Jan 9, 2021
@XhmikosR XhmikosR merged commit 7e6d7b8 into main Jan 10, 2021
v5.0.0-beta2 automation moved this from Approved to Done Jan 10, 2021
@XhmikosR XhmikosR deleted the main-xmr-pkg-vars branch January 10, 2021 06:03
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.6.0 Jan 10, 2021
XhmikosR added a commit that referenced this pull request Jan 10, 2021
package.json: move `version_short` variable under the `config` object

This is so that it works on npm 7.x too.
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked/Manually backported in v4.6.0 Jan 10, 2021
XhmikosR added a commit that referenced this pull request Jan 13, 2021
package.json: move `version_short` variable under the `config` object

This is so that it works on npm 7.x too.
XhmikosR added a commit that referenced this pull request Jan 13, 2021
package.json: move `version_short` variable under the `config` object

This is so that it works on npm 7.x too.
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.6.0
Shipped
v5.0.0-beta2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants