Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use outline:0 rather than outline:none #32751

Merged
merged 1 commit into from Jan 10, 2021
Merged

Consistently use outline:0 rather than outline:none #32751

merged 1 commit into from Jan 10, 2021

Conversation

patrickhlauke
Copy link
Member

just for code consistency, no actual effect on styling per se

@patrickhlauke
Consistently use outline:0 rather than outline:none
f9c2240 
just for code consistency, no actual effect on styling per se
@patrickhlauke patrickhlauke added this to Inbox in v4.6.0 via automation Jan 10, 2021
@patrickhlauke patrickhlauke requested a review from a team as a code owner January 10, 2021 14:49
@patrickhlauke patrickhlauke added this to Inbox in v5.0.0-beta2 via automation Jan 10, 2021
patrickhlauke added a commit that referenced this pull request Jan 10, 2021
@patrickhlauke
Consistently use outline:0 rather than outline:none
ce74dea 
Manual backport of #32751 (which has not been merged yet, but assume it will shortly)
v5.0.0-beta2 automation moved this from Inbox to Approved Jan 10, 2021
@XhmikosR XhmikosR requested a review from mdo January 10, 2021 15:54
@patrickhlauke patrickhlauke merged commit d62d18f into main Jan 10, 2021
v5.0.0-beta2 automation moved this from Approved to Done Jan 10, 2021
@patrickhlauke patrickhlauke deleted the patrickhlauke-outline-consistency branch January 10, 2021 16:13
@patrickhlauke
Copy link
Member Author

damn sorry, missed the request for review from @mdo that @XhmikosR did. please revert if it turns out this was too hasty.

@XhmikosR XhmikosR mentioned this pull request Jan 11, 2021
Merged
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked/Manually backported in v4.6.0 Jan 11, 2021
XhmikosR pushed a commit that referenced this pull request Jan 11, 2021
@patrickhlauke @XhmikosR
Consistently use outline:0 rather than outline:none
d54dc03 
Manual backport of #32751 (which has not been merged yet, but assume it will shortly)
XhmikosR pushed a commit that referenced this pull request Jan 13, 2021
@patrickhlauke @XhmikosR
Consistently use outline:0 rather than outline:none
24f766c 
Manual backport of #32751 (which has not been merged yet, but assume it will shortly)
XhmikosR pushed a commit that referenced this pull request Jan 13, 2021
@patrickhlauke @XhmikosR
Consistently use outline:0 rather than outline:none
e7cbb59 
Manual backport of #32751 (which has not been merged yet, but assume it will shortly)
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Jan 13, 2021
This was referenced Mar 8, 2021
Closed
Merged
Merged
Merged
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
backport-to-v4 css v5
Projects
No open projects
v4.6.0
Shipped
v5.0.0-beta2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrickhlauke @ffoodd