Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darken dropdown item hover style #32754

Merged
merged 1 commit into from Jan 11, 2021

Conversation

patrickhlauke
Copy link
Member

Closes #23329

@patrickhlauke patrickhlauke added this to Inbox in v5.0.0-beta2 via automation Jan 10, 2021
@patrickhlauke patrickhlauke requested a review from a team as a code owner January 10, 2021 17:31
@patrickhlauke
Copy link
Member Author

Not sure if we want to backport this, or if that counts as a breaking visual style...

v5.0.0-beta2 automation moved this from Inbox to Approved Jan 11, 2021
@patrickhlauke patrickhlauke merged commit 78c5b50 into main Jan 11, 2021
v5.0.0-beta2 automation moved this from Approved to Done Jan 11, 2021
@patrickhlauke patrickhlauke deleted the patrickhlauke-dropdown-hover-darker branch January 11, 2021 01:24
@patrickhlauke
Copy link
Member Author

@mdo thoughts on backporting?

@mdo
Copy link
Member

mdo commented Jan 11, 2021

I'm good with a backport @patrickhlauke. This isn't a breaking change IMO.

patrickhlauke added a commit that referenced this pull request Jan 11, 2021
@XhmikosR XhmikosR added this to Inbox in v4.6.0 via automation Jan 11, 2021
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked/Manually backported in v4.6.0 Jan 11, 2021
@XhmikosR XhmikosR added the v4 label Jan 11, 2021
XhmikosR pushed a commit that referenced this pull request Jan 11, 2021
XhmikosR pushed a commit that referenced this pull request Jan 13, 2021
XhmikosR pushed a commit that referenced this pull request Jan 13, 2021
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.6.0
Shipped
v5.0.0-beta2
  
Done
Development

Successfully merging this pull request may close these issues.

V4.beta Dropdown menu focus/hover style constrast too low for accessibility
3 participants