Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint: disallow some property values #32756

Merged
merged 2 commits into from Jan 13, 2021
Merged

Conversation

XhmikosR
Copy link
Member

  • border: none
  • outline: none

Refs #32751

@XhmikosR XhmikosR added the build label Jan 11, 2021
* border: none
* outline: none
@XhmikosR XhmikosR force-pushed the main-xmr-stylelint-disallowed branch from c3fbf04 to 2144539 Compare January 11, 2021 07:41
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea 👍

@XhmikosR XhmikosR requested a review from mdo January 11, 2021 09:15
@XhmikosR
Copy link
Member Author

Not sure if we should backport this, but doing so means we'll have to change any none values.

@mdo your call

@XhmikosR XhmikosR marked this pull request as ready for review January 12, 2021 13:32
@XhmikosR XhmikosR added this to Inbox in v4.6.0 via automation Jan 12, 2021
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Jan 12, 2021
@XhmikosR
Copy link
Member Author

Actually, it seems the related patches have been backported in #32748 so I guess it makes sense to include this in v4.6.0 too?

v5.0.0-beta2 automation moved this from Inbox to Approved Jan 13, 2021
@XhmikosR XhmikosR merged commit ed5ddca into main Jan 13, 2021
v5.0.0-beta2 automation moved this from Approved to Done Jan 13, 2021
@XhmikosR XhmikosR deleted the main-xmr-stylelint-disallowed branch January 13, 2021 08:52
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked/Manually backported in v4.6.0 Jan 13, 2021
XhmikosR added a commit that referenced this pull request Jan 13, 2021
* `border: none`
* `outline: none`
XhmikosR added a commit that referenced this pull request Jan 13, 2021
* `border: none`
* `outline: none`
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.6.0
Shipped
v5.0.0-beta2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants