Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs v4: Sass implementation and rounding precision #32791

Merged
merged 5 commits into from Jan 17, 2021

Conversation

voltaek
Copy link
Contributor

@voltaek voltaek commented Jan 14, 2021

@XhmikosR Here is the backport you requested in #32512.

This makes changes similar to those made to the v5 docs to update and clarify the Sass compiler used and the minimum rounding precision we recommend with it. The details added are linked to from several places now instead of bits of the info being spread throughout the docs.

I added some notes about Node Sass being deprecated and how Dart Sass should be a mostly drop in replacement if the user would need support for newer Sass features or CSS standards. It's still made clear that we build Bootstrap v4 with Node Sass, so I think this is a good balance of telling them it's still alright to compile with it while also giving them options if they need newer features.

@voltaek
Copy link
Contributor Author

voltaek commented Jan 17, 2021

Is this slated for v4.6.0 or will it have to wait until v4.6.1?

@voltaek voltaek force-pushed the v4-docs-sass-compiler-precision branch from f626c8b to 42310bc Compare January 17, 2021 07:29
@voltaek
Copy link
Contributor Author

voltaek commented Jan 17, 2021

Rebased against v4-dev and resolved conflict with mdo's new callout in build-tools.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.6.0
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants