From eb1bf6f27be3da60ed681dc01d9448c5a9b89cc3 Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Thu, 24 Aug 2023 14:47:53 +0200 Subject: [PATCH 1/2] Fix Postcss values parser error --- scss/_button-group.scss | 4 ++-- scss/_pagination.scss | 2 +- scss/_variables.scss | 2 +- scss/forms/_input-group.scss | 2 +- site/assets/scss/_component-examples.scss | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/scss/_button-group.scss b/scss/_button-group.scss index 55ae3f65d255..78e5046ffdfc 100644 --- a/scss/_button-group.scss +++ b/scss/_button-group.scss @@ -39,7 +39,7 @@ // Prevent double borders when buttons are next to each other > :not(.btn-check:first-child) + .btn, > .btn-group:not(:first-child) { - margin-left: calc(#{$btn-border-width} * -1); // stylelint-disable-line function-disallowed-list + margin-left: calc(-1 * #{$btn-border-width}); // stylelint-disable-line function-disallowed-list } // Reset rounded corners @@ -126,7 +126,7 @@ > .btn:not(:first-child), > .btn-group:not(:first-child) { - margin-top: calc(#{$btn-border-width} * -1); // stylelint-disable-line function-disallowed-list + margin-top: calc(-1 * #{$btn-border-width}); // stylelint-disable-line function-disallowed-list } // Reset rounded corners diff --git a/scss/_pagination.scss b/scss/_pagination.scss index f275a62eb4dd..9f09694c30ec 100644 --- a/scss/_pagination.scss +++ b/scss/_pagination.scss @@ -75,7 +75,7 @@ margin-left: $pagination-margin-start; } - @if $pagination-margin-start == calc(#{$pagination-border-width} * -1) { + @if $pagination-margin-start == calc(-1 * #{$pagination-border-width}) { &:first-child { .page-link { @include border-start-radius(var(--#{$prefix}pagination-border-radius)); diff --git a/scss/_variables.scss b/scss/_variables.scss index 7706c0f6a5e0..5cec5e79ca9b 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -1300,7 +1300,7 @@ $pagination-color: var(--#{$prefix}link-color) !default; $pagination-bg: var(--#{$prefix}body-bg) !default; $pagination-border-radius: var(--#{$prefix}border-radius) !default; $pagination-border-width: var(--#{$prefix}border-width) !default; -$pagination-margin-start: calc(#{$pagination-border-width} * -1) !default; // stylelint-disable-line function-disallowed-list +$pagination-margin-start: calc(-1 * #{$pagination-border-width}) !default; // stylelint-disable-line function-disallowed-list $pagination-border-color: var(--#{$prefix}border-color) !default; $pagination-focus-color: var(--#{$prefix}link-hover-color) !default; diff --git a/scss/forms/_input-group.scss b/scss/forms/_input-group.scss index 58e4d409c027..8078ebb151ab 100644 --- a/scss/forms/_input-group.scss +++ b/scss/forms/_input-group.scss @@ -121,7 +121,7 @@ } > :not(:first-child):not(.dropdown-menu)#{$validation-messages} { - margin-left: calc(#{$input-border-width} * -1); // stylelint-disable-line function-disallowed-list + margin-left: calc(-1 * #{$input-border-width}); // stylelint-disable-line function-disallowed-list @include border-start-radius(0); } diff --git a/site/assets/scss/_component-examples.scss b/site/assets/scss/_component-examples.scss index 1d8caed666cc..da2dfed3c7d1 100644 --- a/site/assets/scss/_component-examples.scss +++ b/site/assets/scss/_component-examples.scss @@ -93,13 +93,13 @@ .fixed-top, .sticky-top { position: static; - margin: calc(var(--bd-example-padding) * -1) calc(var(--bd-example-padding) * -1) var(--bd-example-padding); // stylelint-disable-line function-disallowed-list + margin: calc(-1 * var(--bd-example-padding)) calc(-1 * var(--bd-example-padding)) var(--bd-example-padding); // stylelint-disable-line function-disallowed-list } .fixed-bottom, .sticky-bottom { position: static; - margin: var(--bd-example-padding) calc(var(--bd-example-padding) * -1) calc(var(--bd-example-padding) * -1); // stylelint-disable-line function-disallowed-list + margin: var(--bd-example-padding) calc(-1 * var(--bd-example-padding)) calc(-1 * var(--bd-example-padding)); // stylelint-disable-line function-disallowed-list } From 1d0de24bfd328334dea9e1a70dcf64eb67e060c4 Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Thu, 24 Aug 2023 15:02:52 +0200 Subject: [PATCH 2/2] Add workflow not to forget it --- .github/workflows/node-sass.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/node-sass.yml b/.github/workflows/node-sass.yml index c558e447af58..2f3ff65c7070 100644 --- a/.github/workflows/node-sass.yml +++ b/.github/workflows/node-sass.yml @@ -47,3 +47,16 @@ jobs: echo "$SASS_VARS_FOUND" exit 1 fi + + - name: Check built CSS files for PostCSS parser + shell: bash + run: | + POSTCSS_ISSUE_FOUND=$(find "dist-sass/css/" -type f -name "*.css" -print0 | xargs -0 --no-run-if-empty grep -F "\) \* -" || true) + if [[ -z "$POSTCSS_ISSUE_FOUND" ]]; then + echo "All good, no PostCSS issue found!" + exit 0 + else + echo "Found $(echo "$POSTCSS_ISSUE_FOUND" | wc -l | bc) PostCSS issue:" + echo "$POSTCSS_ISSUE_FOUND" + exit 1 + fi