Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite SVG #274

Merged
merged 9 commits into from May 29, 2020
Merged

Sprite SVG #274

merged 9 commits into from May 29, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented May 29, 2020

Builds on and replaces #262 with several changes:

  • Updates docs a smidge around using sprites
  • Replaces homepage grid of icons with sprite; cut around 30% of page file size according to my quick math
  • Adds sprite SVG to the npm package
  • Moves sprite generation to before the site build

@mdo mdo added docs Improvements or additions to documentation icon-request labels May 29, 2020
@mdo mdo merged commit 37d432c into master May 29, 2020
@mdo mdo added this to Done in v1.0.0-alpha5 via automation May 29, 2020
@mdo mdo deleted the bastienmoulia-sprite-svg branch May 29, 2020 20:52
@mdo mdo mentioned this pull request May 30, 2020
@@ -48,14 +49,16 @@
"shx": "^0.3.2",
"stylelint": "^13.5.0",
"stylelint-config-twbs-bootstrap": "^2.0.2",
"svg-sprite": "^1.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is using obsolete dependencies...

@XhmikosR
Copy link
Member

XhmikosR commented Jun 2, 2020

@mdo Also, SVGO does not seem to run for the sprite image?

EDIT: NVM, I see SVGO is the default svg-sprite transform :) Although, not sure what config it's using, but if it works, it works.

EDIT2: What I don't like is that we load another huge file on page load...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation icon-request
Projects
No open projects
v1.0.0-alpha5
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants