Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about multiple packages that expose the same import name? #143

Open
jherland opened this issue Feb 14, 2023 · 0 comments
Open
Labels
P3 minor: not priorized type: feature request

Comments

@jherland
Copy link
Member

From the discussion on PR #139

@Nour-Mws:

So a single import_name can be exposed by multiple packages?
We would have e.g. "retinaface": ["retina-face", "retinaface"]?

@jherland:

Yes! We need some collective thinking on what to do with this information. My first instinct is that if we're able to match an import up to any of the dependencies in that list, then we should just do so, and not notify the user about the others (at least not by default).

This is something to be handled in later PRs anyway. I just wanted to get the basic functionality into FD with this PR. In a future PR, it might be that we want to use the packages_distributions() mapping more directly and throw away find_import_names_from_package_name() altogether.

@mknorps:

And how does importlib resolve the dependency when it domes to calling them? It has a fallback, when cannot find a function in the first dependency and then goes to second and so on? Definitely to be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 minor: not priorized type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants