You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm a little worried about these changes. As I understand it, where run_fawltydeps() can use the cwd to actually set the current working directory for the subprocess, run_fawltydeps_functon() cannot do the same, since everything happens in the same process. Instead, you work around that by passing cwd as a basepath/positional argument instead, and the consequence of that is to adjust the expected output here.
I would like to keep test coverage of the fact that when we work on paths relative to cwd, then that is reflected in the output.
I wonder if we can use monkeypatch.chdir to temporarily change cwd while running the tests? However, it probably means changing run_fawltydeps_function() into a pytest fixture (to have access to monkeypatch).
Alternatively, kick this to a later PR, and leave it as run_fawltydeps() instead of run_fawltydeps_function() for now.
The text was updated successfully, but these errors were encountered:
Following @jherland's comment #271:
The text was updated successfully, but these errors were encountered: