Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom "set" library by Skylib's sets.bzl #1799

Open
aherrmann opened this issue Aug 8, 2022 · 1 comment
Open

Replace custom "set" library by Skylib's sets.bzl #1799

aherrmann opened this issue Aug 8, 2022 · 1 comment
Labels
good first issue P3 minor: not priorized type: feature request

Comments

@aherrmann
Copy link
Member

rules_haskell contains a home-grown set library in haskell/private/set.bzl. However, it's implementation is very similar to the one provided by Skylib. We should switch to the Skylib provided one and remove the homegrown version.
@aherrmann aherrmann mentioned this issue Aug 8, 2022
Merged
evertedsphere added a commit that referenced this issue Nov 25, 2022
@evertedsphere
Replace custom set library by Skylib's sets (#1799)
bf9bd9c
@evertedsphere evertedsphere mentioned this issue Nov 25, 2022
Merged
@evertedsphere
Copy link
Contributor

Skylib's version doesn't expose mutable_{union,difference}, so I've opened bazelbuild/bazel-skylib#415 for that.

evertedsphere added a commit that referenced this issue Nov 25, 2022
@evertedsphere
Replace custom set library by Skylib's sets (#1799)
2146718
@evertedsphere evertedsphere changed the title Replace custom "set" library by Skylib Replace custom "set" library by Skylib's "sets" Nov 25, 2022
@evertedsphere evertedsphere changed the title Replace custom "set" library by Skylib's "sets" Replace custom "set" library by Skylib's sets.bzl Nov 25, 2022
evertedsphere added a commit that referenced this issue Nov 29, 2022
@evertedsphere
Replace custom set library by Skylib's sets (#1799)
d45f901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue P3 minor: not priorized type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aherrmann @evertedsphere