Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor contrast on Notes & Tasks "block menu" #5304

Open
Bonapara opened this issue May 6, 2024 · 3 comments · May be fixed by #5342
Open

Poor contrast on Notes & Tasks "block menu" #5304

Bonapara opened this issue May 6, 2024 · 3 comments · May be fixed by #5342
Assignees
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes type: bug Something isn't working

Comments

@Bonapara
Copy link
Member

Bonapara commented May 6, 2024

Current behavior

The menu contrast is not great

CleanShot 2024-05-06 at 16 06 52

Desired Behavior

It should look like other Menus.

Color: text-secondary
Background: transparent-secondary
backdrop-filter: blur(12px) saturate(200%) contrast(50%) brightness(130%);

CleanShot 2024-05-06 at 16 12 28

@Bonapara Bonapara added type: bug Something isn't working scope: front Issues that are affecting the frontend side only size: minutes good first issue Good for newcomers labels May 6, 2024
Copy link

greptile-apps bot commented May 6, 2024

To resolve the issue of poor contrast on the Notes & Tasks 'block menu', you'll need to adjust the color and background properties to ensure they match the desired specifications. Here are the steps to implement the desired behavior:

  1. Update Background and Text Color:

    • Navigate to /packages/twenty-front/src/modules/ui/theme/constants/BackgroundLight.ts and /packages/twenty-front/src/modules/ui/theme/constants/BackgroundDark.ts.
    • Ensure the transparent-secondary background matches the desired transparency and color.
  2. Adjust Menu Item Styles:

    • In /packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelectColor.tsx, update the MenuItemSelectColor component to use text-secondary for text color and transparent-secondary for background color.
  3. Apply Backdrop Filter:

    • Add the following CSS to the menu's container style: backdrop-filter: blur(12px) saturate(200%) contrast(50%) brightness(130%);.
    • This can be done in a styled component or directly within the component's style attribute, depending on how styles are managed in the project.

These steps specifically target the contrast issue by aligning the menu's appearance with the desired aesthetic, ensuring it matches other menus in terms of text color, background, and overall visual effect.

References

twentyhq/twenty/packages/twenty-front/src/modules/ui/theme/constants/BackgroundDark.ts
twentyhq/twenty/packages/twenty-front/src/modules/ui/theme/constants/BackgroundLight.ts
twentyhq/twenty/packages/twenty-front/src/modules/ui/input/button/components/Button.tsx
twentyhq/twenty/packages/twenty-front/src/modules/ui/input/button/components/IconButton.tsx
twentyhq/twenty/packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelectColor.tsx

Ask Greptile

@its-id
Copy link
Contributor

its-id commented May 7, 2024

@Bonapara can I take it?

@Bonapara
Copy link
Member Author

Bonapara commented May 8, 2024

Sure, thanks @its-id! 🙏

@its-id its-id linked a pull request May 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Bonapara @its-id and others