Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntegrationTestCase: Compatibility with PHPUnit 10 #3810

Open
SiebelsTim opened this issue Feb 10, 2023 · 1 comment · May be fixed by #3813
Open

IntegrationTestCase: Compatibility with PHPUnit 10 #3810

SiebelsTim opened this issue Feb 10, 2023 · 1 comment · May be fixed by #3813

Comments

@SiebelsTim
Copy link

PHPUnit 10 has breaking changes regarding data providers. These must be static now.

However, \Twig\Test\IntegrationTestCase uses non-static data providers.

The errors look like this:

* Data Provider method MyTest::getTests() is not static                                                                                  
                                                                                                                                                                                                                   
* Data Provider method MyTest::getTests() expects an argument

Unfortunately, the needed change looks like a breaking change. IntegrationTestCase::getTests depends on $this->getFixturesDir() which is abstract. Consumers would need to change this as well then.
@fabpot
Copy link
Contributor

fabpot commented Feb 10, 2023

@SiebelsTim Would you like to work on a PR on the 3.x branch to improve the current situation?

SiebelsTim pushed a commit to SiebelsTim/Twig that referenced this issue Feb 15, 2023
Added compatibility with PHPUnit 10 (fixes twigphp#3810)
9291574
@SiebelsTim SiebelsTim linked a pull request Feb 15, 2023 that will close this issue
Open
SiebelsTim pushed a commit to SiebelsTim/Twig that referenced this issue Feb 15, 2023
Fixed codestyle (fixes twigphp#3810)
c2d315f
SiebelsTim pushed a commit to SiebelsTim/Twig that referenced this issue Feb 15, 2023
Fixed codestyle (fixes twigphp#3810)
8c6673f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added compatibility with PHPUnit 10 SiebelsTim/Twig
2 participants
@fabpot @SiebelsTim