fix: Go tests wait for Prism to be responsive #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,4 +9,4 @@ RUN go get -u github.com/twilio/twilio-go@main | |||
| RUN go get -u github.com/twilio/terraform-provider-twilio@main | |||
|
|
|||
| # pipefail prevents errors in a pipeline from being masked. | |||
| CMD ["/bin/bash", "-c", "set -o pipefail && go test ./... -coverprofile /local/coverage.out -json | tee /local/test-report.out"] | |||
| CMD ["/local/wait-for-prism.sh", "/bin/bash", "-c", "set -o pipefail && go test ./... -coverprofile /local/coverage.out -json | tee /local/test-report.out"] | |||
There was a problem hiding this comment.
Since we have multiple services that will be dependent on the prism service being up and running, this script will need to exist in the context for each service. Instead can we replace this with a simple sleep:
CMD ["/bin/bash", "-c", "set -o pipefail && sleep 10 && go test ./... -coverprofile /local/coverage.out -json | tee /local/test-report.out"]
We've done something similar elsewhere which has not shown to have issues: https://github.com/sendgrid/sendgrid-oai/blob/64e32a322832ffea63afcd026e4e6557a04880ba/prism/docker-compose.yml#L8
|
Closing until PR feedback is addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
This PR introduces a bash script that will repeatedly try to access the Prism container on a sample API.
Once a working response is received, the script stops looping and begins executing the passed in command (in this case, go tests).
Checklist
Most of these items do not seem to apply to this change AFAICT.
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-go