Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Settings For Sound Effects & Voice #196

Closed
JAD3N opened this issue Sep 13, 2023 · 4 comments
Closed

Volume Settings For Sound Effects & Voice #196

JAD3N opened this issue Sep 13, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@JAD3N
Copy link

JAD3N commented Sep 13, 2023

Is your feature request related to a problem? Please describe.
Sound effects can be too loud when wearing headphones for some users depending on the speakers etc, controlling this by the system causes problems if they use any other product that provides audio in the browser since it affects everything.

Describe the solution you'd like
I believe 2 controllable options for sound volume and voice volume in the device class would ideally solve the problem.

Describe alternatives you've considered
I've currently replacing the Sound option in device options with a custom class, but something built-in would be more ideal.

Additional context
I was surprised to find that this setting wasn't already built-in. Volume controls are almost a must for any web-based voice application since audio set-ups vary so much.

@JAD3N JAD3N added the enhancement New feature or request label Sep 13, 2023
@charliesantos
Copy link
Collaborator

Hi @JAD3N , thanks for submitting. This has been considered, however, we are not getting enough demands from customers about this feature, making it a low priority for us. But let's keep this ticket open and see if we get more traction.

Just to confirm, by "sound volume" you mean these sounds correct?
And by "voice volume" you mean, the audio that plays out during a call, e.g. the callee's voice, is this correct?

@JAD3N
Copy link
Author

JAD3N commented Sep 13, 2023

Just to confirm, by "sound volume" you mean these sounds correct?
And by "voice volume" you mean, the audio that plays out during a call, e.g. the callee's voice, is this correct?

Yes, that's what I meant. Having a separate volume option for the sound effects like those would be great, since sometimes when a caller is too quiet you would want to boost the volume of the caller but not the sound effects.

Since it would be a low priority task, would submitting a PR for this feature help move this request along?

@charliesantos
Copy link
Collaborator

charliesantos commented Sep 13, 2023

First step would be to collaborate with the public facing APIs, then we can discuss about implementation details after.
But before going to that route, let's see if we have some alternatives.

There's a call.on('audio', handler) API that provides the audio element used for the remote audio. You can use that audio element with an AudioContext, and increase the volume by adjusting the gain value. Don't forget to release any resources after each call to prevent any memory leaks.

@charliesantos
Copy link
Collaborator

Closing this now. We're tracking this feature request internally. Please feel free to follow up if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants