implement tower client #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 30, 2022
Closed
Emilgardis
force-pushed
the
tower
branch
3 times, most recently
from
62258fb
to
c15a725
Compare
Merged
Emilgardis
commented
Apr 30, 2023
src/client/tower_impl.rs
Outdated
Comment on lines
54
to
59
| impl<S, ReqBody> TowerService<S, ReqBody> | ||
| //where | ||
| // S: Service<Request, Response = Response, Error = Err, Future = Fut> + Clone + Send + Sync, | ||
| // Fut: std::future::Future<Output = Result<Response, Err>> + 'static, | ||
| // Err: std::error::Error + Sync + Send + 'static, | ||
| { |
Emilgardis
commented
Apr 30, 2023
| hyper::Client::builder().build::<_, hyper::Body>(hyper_tls::HttpsConnector::new()), | ||
| ); | ||
| tracing::info!("Creating client"); | ||
| let client: HelixClient<Box<dyn twitch_api::HttpClient<Error = _>>> = |
There was a problem hiding this comment.
should do this everywhere, it's great
Emilgardis
force-pushed
the
tower
branch
2 times, most recently
from
1b47141
to
c0a745a
Compare
|
bors r+ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.