Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventsub websocket #291

Merged
merged 8 commits into from
Dec 4, 2022
Merged

eventsub websocket #291

merged 8 commits into from
Dec 4, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis linked an issue Nov 1, 2022 that may be closed by this pull request
EventSub Over WebSocket #290
Open
@Emilgardis
Copy link
Member Author

need #288 which implements attrs on the macros

going to revamp the macros a bit too

Emilgardis
Emilgardis commented Nov 1, 2022
View reviewed changes
Copy link
Member Author

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was easy

src/eventsub/event.rs Outdated Show resolved Hide resolved
src/eventsub/mod.rs Outdated Show resolved Hide resolved
src/eventsub/mod.rs Show resolved Hide resolved
src/helix/endpoints/eventsub/create_eventsub_subscription.rs Show resolved Hide resolved
@Emilgardis Emilgardis force-pushed the eventsub-websocket branch 2 times, most recently from 369fc0c to b9b9c8a Compare November 28, 2022 08:28
@Emilgardis Emilgardis force-pushed the eventsub-websocket branch 3 times, most recently from f9e4b08 to 4c51558 Compare December 3, 2022 12:50
@Emilgardis Emilgardis marked this pull request as ready for review December 3, 2022 15:06
@Emilgardis Emilgardis added the release Mark pr as a release label Dec 4, 2022
@Emilgardis Emilgardis force-pushed the eventsub-websocket branch 2 times, most recently from 562df26 to 14a17f9 Compare December 4, 2022 12:00
@Emilgardis Emilgardis removed the release Mark pr as a release label Dec 4, 2022
Emilgardis
Emilgardis commented Dec 4, 2022
View reviewed changes
src/eventsub/mod.rs Outdated
Comment on lines 699 to 700
/// Websocket was disconnected
WebsocketDisconnected
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

twitchdev/issues#699

@Emilgardis
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 4, 2022

Build succeeded:

@bors bors bot merged commit 0defc9e into main Dec 4, 2022
@bors bors bot deleted the eventsub-websocket branch December 4, 2022 14:59
@Emilgardis Emilgardis mentioned this pull request Dec 4, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nerixyz Nerixyz Nerixyz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EventSub Over WebSocket
2 participants
@Emilgardis @Nerixyz