Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future incompatibility with Rust RFC 3373: Avoid non-local definitions in functions #410

Open
Nerixyz opened this issue Apr 7, 2024 · 0 comments

Comments

@Nerixyz
Copy link
Contributor

Nerixyz commented Apr 7, 2024

CI currently passes, but might break with the 2024 edition. Example:

warning: non-local `impl` definition, they should be avoided as they go against expectation
    --> twitch_oauth2/src/tokens/errors.rs:16:35
     |
  16 | #[derive(thiserror::Error, Debug, displaydoc::Display)]
     |                                   ^^^^^^^^^^^^^^^^^^^
     |
     = help: move this `impl` block outside the of the current constant `_DERIVE_Display_FOR_ValidationError`
     = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
     = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
     = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
     = note: the derive macro `displaydoc::Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc`
     = note: this warning originates in the derive macro `displaydoc::Display` (in Nightly builds, run with -Z macro-backtrace for more info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant