Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable ws rfc ping for chat and pubsub #539

Merged
merged 2 commits into from Feb 14, 2022
Merged

fix: enable ws rfc ping for chat and pubsub #539

merged 2 commits into from Feb 14, 2022

Conversation

PhilippHeuer
Copy link
Member

@PhilippHeuer PhilippHeuer commented Feb 13, 2022 •
edited

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

The Chat connection could end up stuck without reconnecting when losing internet access and not attempting to send any messages

Changes Proposed

  • enable websocket rfc ping with a default of 15s in chat and pubsub
  • add the property wsPingPeriod to all relevant builders for customization

Additional Information

Thanks to Pocketpac for reporting the issue

iProdigy
iProdigy approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@iProdigy iProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating

@PhilippHeuer PhilippHeuer merged commit af5744a into develop Feb 14, 2022
@PhilippHeuer PhilippHeuer deleted the fix/websocket-ping branch February 14, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iProdigy iProdigy iProdigy approved these changes

Assignees
No one assigned
Labels
bug/minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhilippHeuer @iProdigy