refactor: don't block when polling ircCommandQueue #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Issues Fixed
Avoids the following exception from being logged on
ITwitchClient#close
:(the thread still shuts down gracefully, just the exception can appear spooky for a normal operation)
Changes Proposed
ircCommandQueue
for an element (so no more InterruptedException would be fired)Additional Information
flushCommand
is called frequently enough that the blocking poll is not neededThanks to
쩌리곰#3393
for reporting