New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: common websocket client #552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stachu540
reviewed
Mar 12, 2022
client-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnection.java
Show resolved
Hide resolved
iProdigy
reviewed
Mar 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this off the ground!
chat/src/main/java/com/github/twitch4j/chat/enums/TMIConnectionState.java
Show resolved
Hide resolved
...-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnectionConfig.java
Outdated
Show resolved
Hide resolved
...-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnectionConfig.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/github/twitch4j/common/test/TestEventManager.java
Outdated
Show resolved
Hide resolved
pubsub/src/main/java/com/github/twitch4j/pubsub/TwitchPubSub.java
Outdated
Show resolved
Hide resolved
...-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnectionConfig.java
Show resolved
Hide resolved
...-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnectionConfig.java
Outdated
Show resolved
Hide resolved
…eature/websocket-common
iProdigy
reviewed
Mar 24, 2022
client-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnection.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sidd <iProdigy@users.noreply.github.com>
iProdigy
reviewed
May 4, 2022
pubsub/src/main/java/com/github/twitch4j/pubsub/TwitchPubSubBuilder.java
Show resolved
Hide resolved
...-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnectionConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sidd <iProdigy@users.noreply.github.com>
iProdigy
approved these changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Changes Proposed
This improves our testing capabilities in modules that use websocket connections.
and now we can:
Additional Information
This also includes a few example tests for chat / pubSub to show how the usage would look like.