Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate helix user view count and hype train id query param #559

Merged
merged 3 commits into from Apr 10, 2022

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Apr 8, 2022

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • Deprecate User#getViewCount
  • Deprecate TwitchHelix#getHypeTrainEvents(String, String, Integer, String, String)
  • Remove tests for decommissioned endpoints (and convert webhook tests from websub to eventsub)

Additional Information

https://discuss.dev.twitch.tv/t/get-hype-train-events-api-endpoint-id-query-parameter-deprecation/37613
https://discuss.dev.twitch.tv/t/get-users-api-endpoint-view-count-deprecation/37777

@iProdigy iProdigy merged commit 99bfff4 into develop Apr 10, 2022
@iProdigy iProdigy deleted the chore/helix-april-deprecations branch April 10, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants