New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: comply with undocumented helix rate limits #561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iProdigy
changed the title
feat: comply with helix banUser undocumented ratelimit
feat: comply with undocumented helix rate limits
Apr 19, 2022
iProdigy
commented
Apr 19, 2022
rest-helix/src/main/java/com/github/twitch4j/helix/interceptor/TwitchHelixDecoder.java
Outdated
Show resolved
Hide resolved
iProdigy
commented
Apr 20, 2022
...elix/src/main/java/com/github/twitch4j/helix/interceptor/TwitchHelixClientIdInterceptor.java
Outdated
Show resolved
Hide resolved
PhilippHeuer
approved these changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job - and great investigation on the 429's :)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Issues Fixed
Changes Proposed
banUser
/unbanUser
calls to 100/30 bucket per channeladdBlockedTerm
/removeBlockedTerm
calls to 60/60 bucket per channelcreateClip
calls to 600/60 bucket per user