Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: comply with undocumented helix rate limits #561

Merged
merged 11 commits into from May 4, 2022

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Apr 16, 2022

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • Prevents 429's from some helix endpoints with special undocumented rate limits
  • Prevents 429's from consistently hammering (general) helix endpoints (due to refill rate asymmetry)

Changes Proposed

  • Restrict banUser/unbanUser calls to 100/30 bucket per channel
  • Restrict addBlockedTerm/removeBlockedTerm calls to 60/60 bucket per channel
  • Restrict createClip calls to 600/60 bucket per user
  • Reduce helix bucket refill rate to 600/60
  • Allow users to override the global helix ratelimit (to be less than 800/60, for example)
  • Fix resource leak in error decoders

@iProdigy iProdigy changed the title feat: comply with helix banUser undocumented ratelimit feat: comply with undocumented helix rate limits Apr 19, 2022
Copy link
Member

@PhilippHeuer PhilippHeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job - and great investigation on the 429's :)

@iProdigy iProdigy merged commit a1707a9 into develop May 4, 2022
@iProdigy iProdigy deleted the feature/helix-endpoint-limiting branch May 4, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants