feat: add clip creation event fired by client helper #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iProdigy
commented
May 14, 2022
common/src/main/java/com/github/twitch4j/common/util/PaginationUtil.java
Outdated
Show resolved
Hide resolved
twitch4j/src/main/java/com/github/twitch4j/TwitchClientHelper.java
Outdated
Show resolved
Hide resolved
iProdigy
commented
May 15, 2022
common/src/main/java/com/github/twitch4j/common/util/PaginationUtil.java
Outdated
Show resolved
Hide resolved
iProdigy
commented
May 15, 2022
common/src/main/java/com/github/twitch4j/common/util/PaginationUtil.java
Outdated
Show resolved
Hide resolved
PhilippHeuer
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Changes Proposed
ChannelClipCreatedEventand fire it fromTwitchClientHelper(given the appropriate enable method was called)IClientHelperPaginationUtilAdditional Information
Requested a few times on the discord; due to twitch caching, no events are fired for the first 5 mins & afterwards events are fired every ~minute (assuming new clips are being created)