chore: disable circuit breaker on helix bans api #571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Changes Proposed
banUser
/unbanUser
Additional Information
In #561, we already implemented special logic to handle 429's from these endpoints that induces a pause in further requests.
However, twitch also throws errors from this endpoint in more states that can cause needless circuit break tripping (e.g., trying to (un)ban a bunch of users that are already (un)banned), so this PR disables this hystrix behavior for these specific commands