Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement updated soundtrack playlist api #596

Merged
merged 2 commits into from Jul 12, 2022
Merged

feat: implement updated soundtrack playlist api #596

merged 2 commits into from Jul 12, 2022

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jun 28, 2022 •
edited

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • Twitch's breaking changes to getSoundtrackPlaylist made the response no longer deserializable to the specified classes

Changes Proposed

  • Add optional id param to getSoundtrackPlaylists
  • Add undocumented limit/after to getSoundtrackPlaylists & pagination field in SoundtrackPlaylistMetadataList
  • Implement completely different getSoundtrackPlaylist method

Additional Information

  • Twitch made these breaking changes without announcement; see changelog for 2022-06-27
  • As these methods were marked as @Unofficial, we also implement the changes in breaking fashion
  • The actual maximum value for limit is 50, instead of the officially documented 100 - have updated javadocs accordingly

@iProdigy
Copy link
Member Author

iProdigy commented Jul 1, 2022 •
edited

todo: add pagination to getSoundtrackPlaylists (twitchdev/issues#627)

@iProdigy iProdigy marked this pull request as draft July 1, 2022 21:12
@iProdigy iProdigy removed the request for review from PhilippHeuer July 11, 2022 15:55
@iProdigy iProdigy marked this pull request as ready for review July 11, 2022 19:56
@iProdigy iProdigy merged commit 5ae8089 into develop Jul 12, 2022
@iProdigy iProdigy deleted the feature/helix-soundtrack-playlist branch July 12, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer