Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add websocket connection state events / new connection lost state #597

Merged
merged 11 commits into from
Jul 11, 2022
Merged

feat: add websocket connection state events / new connection lost state #597

merged 11 commits into from
Jul 11, 2022
+175 −19

Conversation

samfundev
Copy link
Contributor

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • Websockets now emit events when their state changes
  • Websockets have a new state when their connection is lost

Sorry, something went wrong.

@samfundev
feat: emit websocket events

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
0debe56
@iProdigy
Copy link
Member

iProdigy commented Jul 7, 2022

what's the use case in mind for WebsocketStateEvent?

@samfundev
Copy link
Contributor Author

what's the use case in mind for WebsocketStateEvent?

I'll be using it to show the status of the connection to chat. For example, if the connection gets disconnected that could be displayed to the user.

@iProdigy iProdigy requested a review from PhilippHeuer July 10, 2022 05:29
PhilippHeuer
PhilippHeuer approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@PhilippHeuer PhilippHeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@PhilippHeuer PhilippHeuer changed the title feat: emit websocket events feat: add websocket connection state changed events / new connection lost state Jul 10, 2022
iProdigy
iProdigy approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@iProdigy iProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@PhilippHeuer PhilippHeuer changed the title feat: add websocket connection state changed events / new connection lost state feat: add websocket connection state events / new connection lost state Jul 11, 2022
@PhilippHeuer PhilippHeuer merged commit 6080cde into twitch4j:develop Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iProdigy iProdigy

@PhilippHeuer PhilippHeuer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samfundev @iProdigy @PhilippHeuer