Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear pubsub command queue on reconnect #599

Merged
merged 2 commits into from Jul 9, 2022
Merged

fix: clear pubsub command queue on reconnect #599

merged 2 commits into from Jul 9, 2022

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jul 8, 2022

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • Avoid ping timer related reconnect spam & resulting queue saturation

Changes Proposed

  • Ensure ping timer is reset on each connect, instead of only manual TwitchPubSub#connect calls
  • Ensure command queue is cleared on disconnect (to avoid cases where there were remaining queued commands on a disconnect being compounded with new commands on reconnect from resending subscribed topics)

Additional Information

Thanks to Pocketpac & Doc94 for reporting logs to diagnose the issue

@iProdigy iProdigy merged commit 7e44087 into develop Jul 9, 2022
@iProdigy iProdigy deleted the fix/pubsub-queue-disconnect branch July 9, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
bug/minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer