Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset ping tracker on websocket close #602

Merged
merged 1 commit into from Jul 17, 2022

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • Avoids a very rare edge case where a disconnect could've occurred after a ping was sent but before a pong was received, resulting in a falsely exaggerated latency value on the next pong frame (post-reconnect)

@iProdigy iProdigy merged commit d119698 into develop Jul 17, 2022
@iProdigy iProdigy deleted the fix/reset-latency-socket-close branch July 17, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants