Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: perform more chat token checks #607

Merged
merged 15 commits into from Jul 30, 2022
Merged

feat: perform more chat token checks #607

merged 15 commits into from Jul 30, 2022

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jul 19, 2022 •
edited

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

Changes Proposed

On chat instantiation, add checks for:

  • App access instead of user access passed
  • Token without read scope passed
  • Token without edit scope passed

On chat (re)connect:

  • Add validateTokenOnConnect setting - will automatically connect in read-only mode if chat credential has expired

@iProdigy iProdigy marked this pull request as ready for review July 21, 2022 22:56
@iProdigy iProdigy removed the request for review from PhilippHeuer July 23, 2022 19:00
@iProdigy iProdigy marked this pull request as draft July 23, 2022 19:00
@iProdigy iProdigy marked this pull request as ready for review July 23, 2022 20:08
@iProdigy iProdigy changed the title feat: perform more token checks on chat build feat: perform more chat token checks Jul 25, 2022
@iProdigy iProdigy merged commit 42e9026 into develop Jul 30, 2022
@iProdigy iProdigy deleted the feature/more-token-checks branch July 30, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer