Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add timeout config to websocket #613

Merged
merged 4 commits into from Jul 28, 2022
Merged

feat: add timeout config to websocket #613

merged 4 commits into from Jul 28, 2022

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jul 28, 2022 •
edited by PhilippHeuer

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • Connection/socket timeout previously was infinite

Changes Proposed

  • Add connectionTimeout/socketTimeout to client websocket

@iProdigy iProdigy merged commit 76a42fa into develop Jul 28, 2022
@iProdigy iProdigy deleted the feature/ws-timeout branch July 28, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer