Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve chat regex matching #616

Merged
merged 13 commits into from Jul 31, 2022
Merged

fix: improve chat regex matching #616

merged 13 commits into from Jul 31, 2022

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • MESSAGE_PATTERN was incorrectly matching some messages (e.g., some whispers)

Changes Proposed

  • Require tags/clientName/channel to not contain whitespace characters
  • Unescape more strings in parseBadges
  • Force parseBadges to split key value pairs in up to 2 parts (in case the value also contains /)
  • Use non-regex split in parseBadges for improved performance

@iProdigy iProdigy merged commit 92b0511 into develop Jul 31, 2022
@iProdigy iProdigy deleted the fix/chat-regex-whisper branch July 31, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
bug/minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer