Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use xanthic cache facade #618

Merged
merged 8 commits into from Aug 9, 2022
Merged

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Aug 5, 2022

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • Forced Caffeine use was incompatible with Android

Changes Proposed

  • Switch all direct Caffeine use to the Xanthic facade

Additional Information

For now, we still depend on cache-provider-caffeine to avoid any breaking changes... users can exclude this dependency & specify a different provider

@PhilippHeuer
Copy link
Member

Should we also allow to explicitly set a provider in the builder?

@iProdigy
Copy link
Member Author

iProdigy commented Aug 9, 2022

Should we also allow to explicitly set a provider in the builder?

We have some static final caches where it'd be tricky to pass that state to (e.g., https://github.com/twitch4j/twitch4j/blob/refactor/xanthic-cache/eventsub-common/src/main/java/com/github/twitch4j/eventsub/util/EventSubVerifier.java#L35)

So users can just do CacheApiSettings#setDefaultCacheProvider instead

@iProdigy iProdigy merged commit 48e1917 into develop Aug 9, 2022
@iProdigy iProdigy deleted the refactor/xanthic-cache branch August 9, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants