feat: allow custom websocket close delay #627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Issues Fixed
Changes Proposed
closeDelay
toWebsocketConnectionConfig
WebsocketConnection#close
until the underlyingSocket
has fully closedAdditional Information
nv-websocket-client
defaultscloseDelay
to10_000
- this seems high to just wait for a single frame, so we default to1000
instead (this part of the websocket protocol is just good manners anyway, so it's not the end of the world if formal close isn't received)