Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charity): resolve twitch doc issues #631

Merged
merged 1 commit into from Aug 31, 2022
Merged

fix(charity): resolve twitch doc issues #631

merged 1 commit into from Aug 31, 2022

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Related Issues

Changes Proposed

  • Version for channel.charity_campaign.donate should be beta (this was initially documented as 1, but was silently changed)
  • For ChannelCharityDonateEvent, twitch (mistakenly) sends target_amount as the field name for amount

@iProdigy iProdigy merged commit 6a90523 into develop Aug 31, 2022
@iProdigy iProdigy deleted the fix/twitch-charity-doc-issues branch August 31, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer