Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: avoid regex split on chat message #638

Merged
merged 4 commits into from Sep 4, 2022
Merged

perf: avoid regex split on chat message #638

merged 4 commits into from Sep 4, 2022

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Sep 3, 2022

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • Switches String#split (regex-based) to StringUtils#split (non-regex) for better performance in TwitchChat#onTextMessage

Additional Information

Achieved 9.5% faster parsing in my testing

@iProdigy iProdigy merged commit 1e387c8 into develop Sep 4, 2022
@iProdigy iProdigy deleted the perf/split-irc-message branch September 4, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer