Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: treat id as alias in charity eventsub #654

Merged
merged 1 commit into from Sep 17, 2022
Merged

chore: treat id as alias in charity eventsub #654

merged 1 commit into from Sep 17, 2022

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Related Issues

twitchdev/issues#646

Changes Proposed

Treat id as an alias (instead of property name) for campaignId in ChannelCharityDonateEvent (to smoothly transition on 2022-09-20)

Additional Information

2022-09-16 Changelog entry:

Breaking change to the Beta [channel.charity_campaign.donate](https://dev.twitch.tv/docs/eventsub/eventsub-subscription-types#channelcharity_campaigndonate) EventSub subscription type:

The id field of the [Charity Donation Event](https://dev.twitch.tv/docs/eventsub/eventsub-reference/#charity-donation-event) object will change to campaign_id to better reflect its content on Tuesday, September 20 at 1:00pm PDT.

@iProdigy iProdigy merged commit fbdfdd7 into develop Sep 17, 2022
@iProdigy iProdigy deleted the chore/charity-id-eventsub branch September 17, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer