-
Notifications
You must be signed in to change notification settings - Fork 89
/
ComposeViewModelInjectionCheckTest.kt
207 lines (193 loc) · 7.4 KB
/
ComposeViewModelInjectionCheckTest.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
// Copyright 2022 Twitter, Inc.
// SPDX-License-Identifier: Apache-2.0
package com.twitter.compose.rules.ktlint
import com.pinterest.ktlint.test.KtLintAssertThat.Companion.assertThatRule
import com.pinterest.ktlint.test.LintViolation
import com.twitter.compose.rules.ComposeViewModelInjection
import org.intellij.lang.annotations.Language
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ValueSource
class ComposeViewModelInjectionCheckTest {
private val injectionRuleAssertThat = assertThatRule { ComposeViewModelInjectionCheck() }
@ParameterizedTest
@ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel"])
fun `passes when a weaverViewModel is used as a default param`(viewModel: String) {
@Language("kotlin")
val code =
"""
@Composable
fun MyComposable(
modifier: Modifier,
viewModel: MyVM = $viewModel(),
viewModel2: MyVM = $viewModel(),
) { }
""".trimIndent()
injectionRuleAssertThat(code).hasNoLintViolations()
}
@ParameterizedTest
@ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel"])
fun `overridden functions are ignored`(viewModel: String) {
@Language("kotlin")
val code =
"""
@Composable
override fun Content() {
val viewModel = $viewModel<MyVM>()
}
""".trimIndent()
injectionRuleAssertThat(code).hasNoLintViolations()
}
@ParameterizedTest
@ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel"])
fun `errors when a weaverViewModel is used at the beginning of a Composable`(viewModel: String) {
@Language("kotlin")
val code =
"""
@Composable
fun MyComposable(modifier: Modifier) {
val viewModel = $viewModel<MyVM>()
}
@Composable
fun MyComposableNoParams() {
val viewModel: MyVM = $viewModel()
}
@Composable
fun MyComposableTrailingLambda(block: () -> Unit) {
val viewModel: MyVM = $viewModel()
}
""".trimIndent()
injectionRuleAssertThat(code).hasLintViolations(
LintViolation(
line = 3,
col = 9,
detail = ComposeViewModelInjection.errorMessage(viewModel)
),
LintViolation(
line = 7,
col = 9,
detail = ComposeViewModelInjection.errorMessage(viewModel)
),
LintViolation(
line = 11,
col = 9,
detail = ComposeViewModelInjection.errorMessage(viewModel)
)
)
}
@ParameterizedTest
@ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel"])
fun `errors when a weaverViewModel is used in different branches`(viewModel: String) {
@Language("kotlin")
val code =
"""
@Composable
fun MyComposable(modifier: Modifier) {
if (blah) {
val viewModel = $viewModel<MyVM>()
} else {
val viewModel: MyOtherVM = $viewModel()
}
}
""".trimIndent()
injectionRuleAssertThat(code).hasLintViolations(
LintViolation(
line = 4,
col = 13,
detail = ComposeViewModelInjection.errorMessage(viewModel)
),
LintViolation(
line = 6,
col = 13,
detail = ComposeViewModelInjection.errorMessage(viewModel)
)
)
}
@ParameterizedTest
@ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel"])
fun `fix no args composable function adds the code inside the parentheses`(viewModel: String) {
@Language("kotlin")
val badCode = """
@Composable
fun MyComposableNoParams() {
val viewModel: MyVM = $viewModel()
}
@Composable
fun MyComposableNoParams() {
val viewModel: MyVM = $viewModel(named = "meh")
}
""".trimIndent()
@Language("kotlin")
val expectedCode = """
@Composable
fun MyComposableNoParams(viewModel: MyVM = $viewModel()) {
}
@Composable
fun MyComposableNoParams(viewModel: MyVM = $viewModel(named = "meh")) {
}
""".trimIndent()
injectionRuleAssertThat(badCode).isFormattedAs(expectedCode)
}
@ParameterizedTest
@ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel"])
fun `fix normal args composable function adds the new code at the end`(viewModel: String) {
@Language("kotlin")
val badCode = """
@Composable
fun MyComposable(modifier: Modifier = Modifier) {
val viewModel: MyVM = $viewModel()
}
@Composable
fun MyComposable(modifier: Modifier = Modifier,) {
val viewModel: MyVM = $viewModel()
}
""".trimIndent()
@Language("kotlin")
val expectedCode = """
@Composable
fun MyComposable(modifier: Modifier = Modifier,viewModel: MyVM = $viewModel()) {
}
@Composable
fun MyComposable(modifier: Modifier = Modifier,viewModel: MyVM = $viewModel(),) {
}
""".trimIndent()
injectionRuleAssertThat(badCode).isFormattedAs(expectedCode)
}
@ParameterizedTest
@ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel"])
fun `fix trailing lambda args composable function adds the new code before the trailing lambda`(viewModel: String) {
@Language("kotlin")
val badCode = """
@Composable
fun MyComposableTrailingLambda(block: () -> Unit) {
val viewModel: MyVM = $viewModel()
}
@Composable
fun MyComposableTrailingLambda(text: String, block: () -> Unit) {
val viewModel: MyVM = $viewModel()
}
@Composable
fun MyComposableTrailingLambda(
text: String,
block: () -> Unit
) {
val viewModel: MyVM = $viewModel()
}
""".trimIndent()
@Language("kotlin")
val expectedCode = """
@Composable
fun MyComposableTrailingLambda(viewModel: MyVM = $viewModel(), block: () -> Unit) {
}
@Composable
fun MyComposableTrailingLambda(text: String, viewModel: MyVM = $viewModel(), block: () -> Unit) {
}
@Composable
fun MyComposableTrailingLambda(
text: String, viewModel: MyVM = $viewModel(),
block: () -> Unit
) {
}
""".trimIndent()
injectionRuleAssertThat(badCode).isFormattedAs(expectedCode)
}
}