Add mavericks VM factory function to the list of VM factories #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyee
approved these changes
Oct 2, 2022
| @@ -16,7 +16,7 @@ class ComposeViewModelInjectionCheckTest { | |||
| private val rule = ComposeViewModelInjectionCheck(Config.empty) | |||
|
|
|||
| @ParameterizedTest | |||
| @ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel"]) | |||
| @ValueSource(strings = ["viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel"]) | |||
| fun `passes when a weaverViewModel is used as a default param`(viewModel: String) { | |||
There was a problem hiding this comment.
you can probably make use
val vmNames = arrayOf("viewModel", "weaverViewModel", "hiltViewModel", "injectedViewModel", "mavericksViewModel")
if you want to avoid some of this boilerplate in all the tests
There was a problem hiding this comment.
Yea this is getting old pretty fast
digitalbuddha
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.