Add ComposePreviewNaming rule and support multipreview annotations #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multipreview annotations weren't correctly supported, which caused issues with the `ModifierMissing` rule. This patch does two things to address that: - Have the annotations for multipreviews to be properly named (add Preview/s suffix) - Expand the preview checks to look for `@Preview` / `@WhateverPreview(s)` Fixes #91
mrmans0n
commented
Oct 3, 2022
| @@ -14,8 +14,6 @@ class ComposePreviewPublicCheck(config: Config) : | |||
| TwitterDetektRule(config), | |||
| ComposeKtVisitor by ComposePreviewPublic() { | |||
|
|
|||
| override val autoCorrect: Boolean = true | |||
There was a problem hiding this comment.
this is on purpose, Detekt is super weird with code changes so in a prior patch I removed them all (if they want autofix people can use detekt-formatting which uses ktlint under the hood) -- but left this one behind by mistake.
mrmans0n
requested review from
blundell,
chrisbanes,
digitalbuddha,
flubarb,
jordanterry,
kenyee,
sierraobryan,
taysand,
wsf20 and
YoaliSB
kenyee
approved these changes
Oct 3, 2022
chrisbanes
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multipreview annotations weren't correctly supported, which caused issues with the
ModifierMissingrule. This patch does two things to address that:@Preview/@WhateverPreview(s)Fixes #91