Skip to content

Commit 2a3b6bd

Browse files
committedOct 22, 2023
pkg/kversion: detect 3.6
This does not yet add V3_6_0 since that will require a minor.
1 parent fe5a660 commit 2a3b6bd

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed
 

‎pkg/kversion/kversion.go

+13-1
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,7 @@ func (vs *Versions) versionGuess(opts ...VersionGuessOpt) guess {
304304
{max330, "v3.3"},
305305
{max340, "v3.4"},
306306
{max350, "v3.5"},
307+
{max360, "v3.6"},
307308
} {
308309
for k, v := range comparison.cmp.filter(cfg.listener) {
309310
if v == -1 {
@@ -445,6 +446,10 @@ func V3_3_0() *Versions { return zkBrokerOf(max330) }
445446
func V3_4_0() *Versions { return zkBrokerOf(max340) }
446447
func V3_5_0() *Versions { return zkBrokerOf(max350) }
447448

449+
/* TODO wait for franz-go v1.16
450+
func V3_6_0() *Versions { return zkBrokerOf(max360) }
451+
*/
452+
448453
func zkBrokerOf(lks listenerKeys) *Versions {
449454
return &Versions{lks.filter(zkBroker)}
450455
}
@@ -1051,8 +1056,15 @@ var max350 = nextMax(max340, func(v listenerKeys) listenerKeys {
10511056
return v
10521057
})
10531058

1059+
var max360 = nextMax(max350, func(v listenerKeys) listenerKeys {
1060+
// KAFKA-14402 29a1a16668d76a1cc04ec9e39ea13026f2dce1de KIP-890
1061+
// Later commit swapped to stable
1062+
v[24].inc() // 4 add partitions to txn
1063+
return v
1064+
})
1065+
10541066
var (
1055-
maxStable = max350
1067+
maxStable = max360
10561068
maxTip = nextMax(maxStable, func(v listenerKeys) listenerKeys {
10571069
return v
10581070
})

0 commit comments

Comments
 (0)