Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich "read from broker errored, killing connection" log message with the Kafka message type #719

Closed
pracucci opened this issue May 8, 2024 · 1 comment · Fixed by #723
Closed

Enrich "read from broker errored, killing connection" log message with the Kafka message type #719

pracucci opened this issue May 8, 2024 · 1 comment · Fixed by #723
Labels
has pr

Comments

@pracucci
Copy link
Contributor

pracucci commented May 8, 2024

I propose to enrich the read from broker errored, killing connection log message adding the Kafka message type as an extra log field. Are you open to such change? If so, I can open a PR.
@twmb
Copy link
Owner

twmb commented May 8, 2024

Sure, feel free to expand some other log lines while at it, too :)

@pracucci pracucci mentioned this issue May 9, 2024
Merged
@twmb twmb added the has pr label May 23, 2024
@twmb twmb closed this as completed in #723 May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add request type to 'read from broker errored' log pracucci/franz-go
2 participants
@twmb @pracucci