fix: Only invoke diff pager if command modifies filesystem

Author: twpayne

internal/cmd/config.go

@@ -1992,7 +1992,9 @@ func (c *Config) persistentPreRunRootE(cmd *cobra.Command, args []string) error
 		c.sourceSystem = chezmoi.NewDryRunSystem(c.sourceSystem)
 		c.destSystem = chezmoi.NewDryRunSystem(c.destSystem)
 	}
-	if c.Verbose || annotations.hasTag(outputsDiff) {
+	if annotations.hasTag(outputsDiff) ||
+		c.Verbose &&
+			(annotations.hasTag(modifiesDestinationDirectory) || annotations.hasTag(modifiesSourceDirectory)) {
 		// If the user has configured a diff pager, then start it as a process.
 		// Otherwise, write the diff output directly to stdout.
 		var writer io.Writer

internal/cmd/statuscmd.go

@@ -28,7 +28,6 @@ func (c *Config) newStatusCmd() *cobra.Command {
 		RunE:              c.runStatusCmd,
 		Annotations: newAnnotations(
 			dryRun,
-			modifiesDestinationDirectory,
 			persistentStateModeReadMockWrite,
 			requiresSourceDirectory,
 		),

internal/cmd/testdata/scripts/issue3257.txtar

@@ -0,0 +1,26 @@
+[windows] skip 'UNIX only'
+
+chmod 755 bin/custom-pager
+
+# test that chezmoi add invokes the pager when verbose is set
+exec chezmoi add $HOME${/}.file
+stdout custom-pager
+
+# test chat chezmoi chattr invokes the pager when verbose is set
+exec chezmoi chattr +private $HOME${/}.file
+stdout custom-pager
+
+# test that chezmoi status does not invoke the pager when verbose is set
+exec chezmoi status
+! stdout custom-pager
+
+-- bin/custom-pager --
+#!/bin/sh
+
+echo custom-pager
+-- home/user/.config/chezmoi/chezmoi.yaml --
+pager: custom-pager
+verbose: true
+-- home/user/.file --
+# contents of .file
+-- home/user/.local/share/chezmoi/.keep --