feat: Warn when overriding CHEZMOI_ env vars

twpayne · halostatue · twpayne · commit f47c2687f8f6 · 2023-10-10T21:28:54.000+02:00
Co-authored-by: Austin Ziegler &lt;austin@zieglers.ca&gt;
diff --git a/internal/cmd/config.go b/internal/cmd/config.go
@@ -2125,6 +2125,9 @@ func (c *Config) persistentPreRunRootE(cmd *cobra.Command, args []string) error
 		}
 	}
 	for key, value := range c.ScriptEnv {
+		if strings.HasPrefix(key, "CHEZMOI_") {
+			c.errorf("warning: %s: overriding reserved environment variable", key)
+		}
 		os.Setenv(key, value)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2125,6 +2125,9 @@ func (c Config) persistentPreRunRootE(cmd cobra.Command, args []string) error`
`2125`	`2125`	`}`
`2126`	`2126`	`}`
`2127`	`2127`	`for key, value := range c.ScriptEnv {`
	`2128`	`+ if strings.HasPrefix(key, "CHEZMOI_") {`
	`2129`	`+ c.errorf("warning: %s: overriding reserved environment variable", key)`
	`2130`	`+ }`
`2128`	`2131`	`os.Setenv(key, value)`
`2129`	`2132`	`}`
`2130`	`2133`