Install ec-typescript as a dependency for addons

[ro0gr]

Seems like ember-cli-typescript isn't supposed to work when installed as a dev dep to the host addon. I've just got a blank screen due to missing assets in my case.

In the build output I've seen a warning:

ember-cli-typescript should be included in your dependencies, not devDependencies

which was great cause it finally led me to a fix. But the question is whether we should convert it to error? Seems like nothing works anyways with ec-ts in the addon dev deps..

Also I've found I just wasn't careful enough, cause there are special installation instructions for addon case:

ember install ember-cli-typescript --save

However, I feel it still can be better if we take care of this installation difference in the blueprint. Which would to allow install this addon by simply running ember install ember-cli-typescript.

At the moment I'd like to know if the feature makes sense here?

[chriskrycho]

We've been EmberConf-ing and traveling back from that; one of us will get back to you in the next few (work) days!

[chriskrycho]

@ro0gr this seems like a great idea, do you mind rebasing this and we'll iterate forward with you on it?

[ro0gr]

@chriskrycho sure, will do.

[ro0gr]

I've just updated docs and tests, rebased and squashed.

According to Azure there is a test failure:

$ mocha --recursive js/tests -R xunit -O output=node-tests.xml
indexDeclarations is not defined (Error in blueprint template: /home/vsts/work/1/s/node_modules/ember-cli-typescript/blueprint-files/ember-cli-typescript/types/app_name/index.d.ts)
ReferenceError: indexDeclarations is not defined (Error in blueprint template: /home/vsts/work/1/s/node_modules/ember-cli-typescript/blueprint-files/ember-cli-typescript/types/app_name/index.d.ts)

But that doesn't seem like related one. At least I can see the same failure on a sibling PRs

[chriskrycho]

Thanks again for doing this! On Wednesday (after we've finally fully cleared our backlog of built-up PRs), would you mind rebasing this? We'll coordinate with you to get it polished and integrated! Sorry about the delay. 😅

[chriskrycho]

Same comment as in the README.