Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including ember-cli-typescript into an app with ember-cli-babel@7.7+ emits warnings #707

Closed
rwjblue opened this issue May 2, 2019 · 6 comments
Milestone

Comments

@rwjblue
Copy link
Contributor

rwjblue commented May 2, 2019

What are instructions we can follow to reproduce the issue?

ember new test-ts-warning
cd test-ts-warning
ember install ember-cli-typescript
ember build

Now about that bug. What did you expect to see?

No console warnings.

What happened instead?

The following warnings are emitted:

WARNING: test-ts-warning has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
WARNING: test-ts-warning has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
@rwjblue
Copy link
Contributor Author

rwjblue commented May 2, 2019

Will be fixed by #640

@bartocc
Copy link

bartocc commented Jul 17, 2019

#640 has been superseeded by #730

@chriskrycho
Copy link
Member

Thanks for flagging it up, @bartocc! This is indeed resolved by #730, now closed.

@chriskrycho chriskrycho added this to the v3.0 milestone Jul 17, 2019
@lolmaus
Copy link

lolmaus commented Aug 27, 2019

Hi! I'm using ember-cli-typescript@2.0.2 which seems to include this PR: https://github.com/typed-ember/ember-cli-typescript/commits/master?after=03134c31ab25ab7ffef60b6fee1b32cc9f1fadc1+104

But I'm still seeing this in the terminal:

WARNING: wbc has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
WARNING: wbc has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
WARNING: wbc has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
WARNING: wbc has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.

How to get rid of those?

I've checked yarn.lock, and the only addons using class-properties are ember-cli-babel and ember-cli-typescript.

@dfreeman
Copy link
Member

@lolmaus v2.0.2 doesn't include a fix for this yet: https://github.com/typed-ember/ember-cli-typescript/commits/v2.0.2

Instead we opted to drop support for ember-cli-babel < 7.7.3 completely, which is a breaking change that's queued up with a few other things for a 3.0 release, which will hopefully be coming soon! We just have a few last things to wrap up in the meantime.

@lolmaus
Copy link

lolmaus commented Aug 27, 2019

@dfreeman Thx for the clarification! 🙇

CC @simonihmig @nickschot @andreasschacht

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants