Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort prereleases by number within them (e.g., M9 < M10) #14

Open
rossabaker opened this issue Dec 30, 2021 · 3 comments
Open

Sort prereleases by number within them (e.g., M9 < M10) #14

rossabaker opened this issue Dec 30, 2021 · 3 comments
Assignees
@j-mie6
Labels
enhancement help wanted versioning

Comments

@rossabaker
Copy link
Member

Context: https://github.com/typelevel/sbt-typelevel/pull/12/files/ddf26e78666fdce3953581dd99e7a49ea79d4111#diff-f515c6fb650430625373f4dee21cd53c79e9464b0ab728b8fa02b25ee2dd6f47
@rossabaker rossabaker mentioned this issue Dec 30, 2021
Merged
@armanbilge
Copy link
Member

armanbilge commented Dec 30, 2021 •
edited

It's hard/impossible to anticipate all pre-release versioning schemes, so my suggestion is we support:

  1. the Ms and RCs, which are used by Scala itself and several typelevel projects
  2. the output of git describe, which is tag[-distance]-hash (this is what the built-in versioning emulates).

@armanbilge
Copy link
Member

armanbilge commented Jan 3, 2022 •
edited

Found some prior art:
https://github.com/scalacenter/versions
sbt/librarymanagement#239
https://github.com/scalacenter/scaladex/blob/52c9be0acc4230f8d9ad600ede5900d35a093acc/core/shared/src/main/scala/scaladex/core/model/SemanticVersion.scala

@armanbilge
Copy link
Member

I bet steward does something smart with version sorting actually.

@armanbilge armanbilge mentioned this issue Feb 3, 2022
Closed
@armanbilge armanbilge mentioned this issue Jun 1, 2022
Closed
@armanbilge armanbilge pinned this issue Jun 1, 2022
@j-mie6 j-mie6 self-assigned this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-mie6 j-mie6

Labels
enhancement help wanted versioning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rossabaker @armanbilge @j-mie6