From 17f2fff359f8626d0593d6ef4b659593e9fb60e9 Mon Sep 17 00:00:00 2001 From: weeix Date: Wed, 11 Mar 2020 20:01:28 +0700 Subject: [PATCH] feat: UpdateResult returns affected rows in mysql (#5628) Set 'affected' property for 'UpdateResult' returned by MySQL Closes: #1308 --- src/query-builder/UpdateQueryBuilder.ts | 4 ++++ test/github-issues/1308/issue-1308.ts | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/query-builder/UpdateQueryBuilder.ts b/src/query-builder/UpdateQueryBuilder.ts index 1bf6c68b6d..49eec26d2a 100644 --- a/src/query-builder/UpdateQueryBuilder.ts +++ b/src/query-builder/UpdateQueryBuilder.ts @@ -104,6 +104,10 @@ export class UpdateQueryBuilder extends QueryBuilder implements updateResult.raw = result[0]; updateResult.affected = result[1]; } + else if (this.connection.driver instanceof MysqlDriver) { + updateResult.raw = result; + updateResult.affected = result.affectedRows; + } else { updateResult.raw = result; } diff --git a/test/github-issues/1308/issue-1308.ts b/test/github-issues/1308/issue-1308.ts index 679b6de2c9..a6d6aecb78 100644 --- a/test/github-issues/1308/issue-1308.ts +++ b/test/github-issues/1308/issue-1308.ts @@ -11,7 +11,7 @@ describe("github issues > #1308 Raw Postgresql Update query result is always an (connections = await createTestingConnections({ entities: [new EntitySchema(AuthorSchema), new EntitySchema(PostSchema)], dropSchema: true, - enabledDrivers: ["postgres"], + enabledDrivers: ["postgres", "mysql", "mariadb"], })) ); beforeEach(() => reloadTestingDatabases(connections));